Skip to content

fix(test): expect 4404 close code for disabled embedded chat - #38841

Merged
teknium1 merged 1 commit into
mainfrom
fix/web-server-disabled-chat-close-code
Jun 4, 2026
Merged

fix(test): expect 4404 close code for disabled embedded chat#38841
teknium1 merged 1 commit into
mainfrom
fix/web-server-disabled-chat-close-code

Conversation

@teknium1

@teknium1 teknium1 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the red test (2) / test (4) shards on main — the disabled-embedded-chat test now expects the correct WebSocket close code.

PR #38743 split the dashboard PTY WebSocket refusal codes — 4404 = embedded chat disabled, 4403 = host/origin mismatch (documented at the refusal site in hermes_cli/web_server.py) — but left test_rejects_when_embedded_chat_disabled asserting the old 4403. The server now sends 4404 for that path, so the test fails assert 4404 == 4403. Main CI has been red since 6717914e0.

Changes

  • tests/hermes_cli/test_web_server.py: update the disabled-chat assertion 4403 → 4404 to match the server's current close code.

Validation

Before After
TestPtyWebSocket::test_rejects_when_embedded_chat_disabled assert 4404 == 4403 fail pass
TestPtyWebSocket class (12 tests) 1 failed 12 passed

Infographic

web-server-close-code-fix

@teknium1
fix(test): expect 4404 close code for disabled embedded chat
249583b 
PR #38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: fix/web-server-disabled-chat-close-code vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9788 on HEAD, 9788 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5081 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@teknium1
teknium1 merged commit fe709a4 into main Jun 4, 2026
23 checks passed
@teknium1
teknium1 deleted the fix/web-server-disabled-chat-close-code branch June 4, 2026 08:13
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists labels Jun 4, 2026
Yuki-14544869 pushed a commit to Yuki-14544869/hermes-agent that referenced this pull request Jun 4, 2026
@teknium1 @Yuki-14544869
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
f77996b 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
davidgut1982 pushed a commit to davidgut1982/hermes-agent that referenced this pull request Jun 5, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
1a0488f 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
changman pushed a commit to changman/hermes-agent that referenced this pull request Jun 10, 2026
@teknium1 @changman
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
bfaa987 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
alt-glitch pushed a commit that referenced this pull request Jun 14, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (#38841)
75e5091 
PR #38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
kossteg pushed a commit to kossteg/hermes-agent that referenced this pull request Jun 16, 2026
@teknium1 @kossteg
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
14d0774 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
f8cd170 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
a9f9656 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
1576f7d 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request Jul 13, 2026
@teknium1 @donbowman
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
8a9a9fd 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
2e2467a 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
@zhenheco zhenheco mentioned this pull request Jul 21, 2026
Closed
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
@teknium1
fix(test): expect 4404 close code for disabled embedded chat (NousRes…
d47e8be 
…earch#38841)

PR NousResearch#38743 split the dashboard PTY WebSocket refusal codes (4404 = chat
disabled, 4403 = host/origin mismatch — see web_server.py refusal site
comment) but left test_rejects_when_embedded_chat_disabled asserting the
old 4403, so it has expected 4403 while the server sends 4404. Main CI has
been red on test (2)/(4) shards since that commit. Update the assertion to
4404 to match the disabled-chat path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/test Test coverage or test infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teknium1 @alt-glitch