fix(desktop): ignore IME composition Enter shortcuts - #38785
Closed
Yuxin-Qiao wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 4, 2026
Yuxin-Qiao
force-pushed
the
fix/desktop-ime-composition-enter
branch
from
June 4, 2026 08:32
1ecad83 to
64dc7a7
Compare
Yuxin-Qiao
force-pushed
the
fix/desktop-ime-composition-enter
branch
from
June 4, 2026 08:34
64dc7a7 to
a5d8697
Compare
Author
|
Validation update:
I have not run a full Electron/macOS manual IME session in this environment, so the above is code-level validation plus focused helper coverage. |
Author
|
Closing as superseded by later Desktop composer work and the repository’s newer IME-focused implementations. This branch is now conflicting and thousands of commits behind current main, while the composer has undergone substantial refactoring since this patch. Reworking this exact branch would duplicate active IME efforts; any remaining bug should be addressed from current main with a fresh reproduction. |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Desktop Enter-key handlers so Enter used to commit IME composition does not also trigger submit/save actions.
This is a narrow macOS/CJK input quality fix and does not overlap with the larger Desktop i18n/localization work.
Changes
isImeComposing()helper forKeyboardEvent.isComposingplus legacykeyCode === 229Why
Chinese/Japanese/Korean IMEs use Enter to commit the current candidate. Without this guard, Hermes Desktop can submit or save while the user is still composing text.
Test plan
Fixes #37483