[codex] Fix dashboard Host allowlist for loopback reverse proxies - #38766
Closed
iseff wants to merge 1 commit into
Closed
[codex] Fix dashboard Host allowlist for loopback reverse proxies#38766iseff wants to merge 1 commit into
iseff wants to merge 1 commit into
Conversation
iseff
force-pushed
the
fix/dashboard-tailscale-host-header
branch
from
June 4, 2026 07:47
f415f2b to
128b6d4
Compare
iseff
force-pushed
the
fix/dashboard-tailscale-host-header
branch
from
June 4, 2026 10:22
128b6d4 to
f9a9119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes dashboard --allowed-hostplusHERMES_DASHBOARD_ALLOWED_HOSTSanddashboard.allowed_hostsRoot cause
The dashboard's DNS-rebinding guard correctly rejected non-loopback
Hostheaders when the backend was bound to127.0.0.1, but that also blocked legitimate requests arriving through a trusted loopback reverse proxy or Tailscale Serve MagicDNS hostname.What changed
0.0.0.0behavior unchanged--insecureValidation
scripts/run_tests.sh tests/hermes_cli/test_web_server_host_header.py tests/hermes_cli/test_dashboard_auth_gate.py tests/hermes_cli/test_dashboard_auth_ws_auth.pyruff check hermes_cli/web_server.py hermes_cli/main.py hermes_cli/config.py tests/hermes_cli/test_web_server_host_header.py tests/hermes_cli/test_dashboard_auth_gate.py