Conversation
sasan1200
force-pushed
the
codex/upstream-tool-progress-metadata
branch
3 times, most recently
from
June 4, 2026 09:00
8af7132 to
3561aa2
Compare
1 task
sasan1200
force-pushed
the
codex/upstream-tool-progress-metadata
branch
3 times, most recently
from
June 4, 2026 17:58
f2aefb2 to
a0bc6d6
Compare
sasan1200
force-pushed
the
codex/upstream-tool-progress-metadata
branch
from
June 4, 2026 18:09
a0bc6d6 to
fccafca
Compare
Author
|
Closing as superseded: the merged observer telemetry hooks in #38232 already expose |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds structured tool-progress metadata for tool callbacks and exposes a defensive
on_tool_progressplugin hook.This lets plugin authors and external control planes observe tool lifecycle events without scraping CLI display text. The important value is correlation: concurrent tool calls can now be matched by
tool_call_idfromtool.startedthroughtool.completed, while existing callback behavior such asresult=on completion remains intact.Related Issue
No issue.
Related but not duplicative:
Type of Change
Changes Made
agent/tool_executor.py: passestool_call_idthroughtool.startedandtool.completedprogress callbacks in both concurrent and sequential execution paths.cli.py: invokes theon_tool_progressplugin hook from the existing CLI progress callback while preserving core scrollback behavior.hermes_cli/plugins.py: registerson_tool_progressas a valid plugin hook.tests/cli/test_tool_progress_scrollback.py: covers plugin hook invocation and metadata forwarding.tests/hermes_cli/test_plugins.py: covers hook registration.tests/run_agent/test_tool_call_guardrail_runtime.py: verifies callback metadata while preserving completionresult=behavior.How to Test
Result:
17 passed, 82 deselected.PYTHONPATH="$PWD" python -m pytest tests/cli/test_tool_progress_scrollback.py tests/run_agent/test_tool_call_guardrail_runtime.py tests/hermes_cli/test_plugins.py -q --tb=short -p no:xdist -o addopts=Result:
99 passed.python -m ruff check . git diff --check upstream/main git merge-tree upstream/main HEADResults: ruff passed, diff-check passed, and merge-tree returned a clean tree id with no conflicts.
CI / Baseline Note
The full-suite checkbox below is intentionally left unchecked. This PR was validated with the focused tool-progress tests, the complete touched test files, lint, whitespace, and merge conflict preview.
After the latest synchronize, GitHub currently reports an empty status check rollup for this fork PR, so there is no upstream CI result to claim here. That is outside this code change; the exact local gates above passed.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — N/Acli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/AScreenshots / Logs
Not applicable.