fix(gateway): use get_hermes_dir for WhatsApp LID session path (#36664) - #38712
Closed
ashishpatel26 wants to merge 1 commit into
Closed
fix(gateway): use get_hermes_dir for WhatsApp LID session path (#36664)#38712ashishpatel26 wants to merge 1 commit into
ashishpatel26 wants to merge 1 commit into
Conversation
expand_whatsapp_aliases() read alias mappings from the hardcoded legacy
path get_hermes_home()/whatsapp/session. The adapter writes to the modern
consolidated path via get_hermes_dir('platforms/whatsapp/session',
'whatsapp/session'). On fresh installs the paths differ, so the resolver
found zero mappings and silently dropped inbound LID messages.
Fix: use get_hermes_dir() in the resolver so both reader and writer
always agree on the session directory.
Closes NousResearch#36664
alt-glitch
added
type/bug
teknium1
added
sweeper:risk-message-delivery
7 tasks
Contributor
|
Closing as a duplicate of #36664. The same one-line fix was merged via PR #54083, salvaged from @fesalfayed's #36665 (submitted first, June 1). Thanks for catching this independently — credited here for the duplicate fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36664. expand_whatsapp_aliases() read from hardcoded legacy path; adapter writes to modern consolidated path via get_hermes_dir(). On fresh installs the paths differ so LID messages silently dropped. Fix: use get_hermes_dir() in resolver.