Skip to content

fix(memory): fall back to pip when uv is unavailable (salvage #5954) - #38668

Merged
benbarclay merged 1 commit into
mainfrom
salvage/5954-pip-fallback
Jun 4, 2026
Merged

fix(memory): fall back to pip when uv is unavailable (salvage #5954)#38668
benbarclay merged 1 commit into
mainfrom
salvage/5954-pip-fallback

Conversation

@benbarclay

@benbarclay benbarclay commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Salvages #5954 by @MustafaKara7.

Problem

_install_dependencies in hermes_cli/memory_setup.py (the hermes memory setup path) hard-aborts with ⚠ uv not found — cannot install dependencies whenever uv is not on PATH — even when a perfectly usable pip is present. Slim container images and some CI environments don't ship uv, so memory-provider dependency installation dead-ends there for no reason.

Fix

  • uv present → uv pip install --python <python> ... (unchanged).
  • uv absent but pip3/pip present → fall back to <python> -m pip install ....
  • Neither present → abort with the original uv-install hint.
  • The "Run manually:" hints now reflect whichever installer was selected.

Differences from #5954

@MustafaKara7's original patch added redundant local import subprocess / import sys inside the install block — both are already in scope (sys is a module-level import; subprocess is imported at the top of the function). This salvage drops those redundant imports and adds a regression test.

Tests

New TestInstallDependenciesRunner in tests/hermes_cli/test_memory_setup_provider_arg.py covers all three paths (uv / pip-fallback / abort).

Adversarial verification: reverted hermes_cli/memory_setup.py to origin/main and ran the new tests — test_falls_back_to_pip_when_uv_missing fails with the exact dead-end symptom (cmd is None, "cannot install dependencies" printed); restoring the fix makes all 7 tests in the file pass. ruff check clean.

Closes #5954.

Co-authored-by: MustafaKara7 186085093+MustafaKara7@users.noreply.github.com

@benbarclay
benbarclay requested a review from teknium1 June 4, 2026 03:13
@github-actions

github-actions Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔎 Lint report: salvage/5954-pip-fallback vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9782 on HEAD, 9782 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5074 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles labels Jun 4, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage #5954)
516e6ba 
`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages #5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes #5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
@benbarclay
benbarclay force-pushed the salvage/5954-pip-fallback branch from 602784d to 516e6ba Compare June 4, 2026 03:54
@benbarclay
benbarclay merged commit 30c7b78 into main Jun 4, 2026
23 checks passed
@benbarclay
benbarclay deleted the salvage/5954-pip-fallback branch June 4, 2026 04:03
@benbarclay benbarclay mentioned this pull request Jun 4, 2026
Closed
Yuki-14544869 pushed a commit to Yuki-14544869/hermes-agent that referenced this pull request Jun 4, 2026
@benbarclay @MustafaKara7 @Yuki-14544869
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
3ea0a6d 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
davidgut1982 pushed a commit to davidgut1982/hermes-agent that referenced this pull request Jun 5, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
d09f826 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
changman pushed a commit to changman/hermes-agent that referenced this pull request Jun 10, 2026
@benbarclay @MustafaKara7 @changman
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
7c2b476 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
alt-glitch pushed a commit that referenced this pull request Jun 14, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage #5954) (#…
09c74e9 
…38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages #5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes #5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
kossteg pushed a commit to kossteg/hermes-agent that referenced this pull request Jun 16, 2026
@benbarclay @MustafaKara7 @kossteg
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
a3f8960 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
17059af 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
078a832 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
4c5ad0f 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request Jul 13, 2026
@benbarclay @MustafaKara7 @donbowman
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
cd5e550 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
ccda591 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
@zhenheco zhenheco mentioned this pull request Jul 21, 2026
Closed
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
@benbarclay @MustafaKara7
fix(memory): fall back to pip when uv is unavailable (salvage NousRes…
94b5f07 
…earch#5954) (NousResearch#38668)

`_install_dependencies` (hermes memory setup) hard-aborted with
"uv not found — cannot install dependencies" whenever `uv` was not on
PATH, even when a perfectly good `pip` was available. Slim container
images and some CI environments don't ship uv, so memory-provider
dependency installation dead-ended there for no good reason.

Now: use `uv pip install` when uv is present, otherwise fall back to
`<python> -m pip install` when pip3/pip is available, and only abort
(with the uv install hint) when neither is found. The "Run manually:"
hints reflect whichever installer was selected.

Salvages NousResearch#5954 by @MustafaKara7. Their patch added redundant local
`import subprocess` / `import sys` (both are already in scope — module
-level `sys`, function-top `subprocess`); this salvage drops those and
adds a regression test (TestInstallDependenciesRunner) covering all
three paths (uv / pip-fallback / abort). Verified adversarially: the
pip-fallback test fails against origin/main's unfixed code with the
exact dead-end symptom and passes with the fix.

Closes NousResearch#5954.

Co-authored-by: MustafaKara7 <186085093+MustafaKara7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teknium1 teknium1 Awaiting requested review from teknium1

Assignees

No one assigned

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benbarclay @alt-glitch