fix(config): bridge docker_volumes and docker_forward_env in config set - #38611
Merged
benbarclay merged 2 commits intoJun 4, 2026
Merged
Conversation
davidgut1982
pushed a commit
to davidgut1982/hermes-agent
that referenced
this pull request
Jun 5, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
…et (#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
kossteg
pushed a commit
to kossteg/hermes-agent
that referenced
this pull request
Jun 16, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
donbowman
pushed a commit
to donbowman/hermes-agent
that referenced
this pull request
Jul 13, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…et (NousResearch#38611) Co-authored-by: Ben Barclay <ben@nousresearch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
terminal.*settings are read byterminal_toolfromTERMINAL_*envvars, so config values must be bridged into the environment at three points:
cli.py→env_mappingsgateway/run.py→_terminal_env_maphermes_cli/config.py:set_config_value→_config_to_env_syncterminal.docker_volumesandterminal.docker_forward_envwere wired intothe first two but missing from the third. As a result, running:
updated
config.yamlbut left the live process'sTERMINAL_DOCKER_VOLUMESstale — the bind mounts (and forwarded env vars) silently did nothing until
a full restart. Users saw "I saved the setting, but it isn't applied."
This is the same drift class already fixed for
docker_run_as_host_userand
docker_mount_cwd_to_workspace.Fix
Add both keys to
_config_to_env_syncinset_config_value. No newserialization logic is introduced: these are JSON-valued keys that
terminal_toolparses viajson.loads, and the existingstr(value)path already produces valid JSON — identical to how the neighboring
terminal.docker_envkey is handled.save_env_value()updatesos.environand invalidates the env cache, so the change takes effect inthe running process immediately.
Tests
test_docker_volumes_is_bridged_everywhereandtest_docker_forward_env_is_bridged_everywhere, pinning all four bridgepoints (the established pattern for this regression class).
test_save_config_set_supports_critical_bridged_keysdocstring, which previously listed these two keys as known gaps.
How to test
Regression suite: