Skip to content

fix(desktop): detect linux arm64 binary - #38594

Merged
ethernet8023 merged 1 commit into
mainfrom
ethie/arm64-fix
Jun 4, 2026
Merged

fix(desktop): detect linux arm64 binary#38594
ethernet8023 merged 1 commit into
mainfrom
ethie/arm64-fix

Conversation

@ethernet8023

Copy link
Copy Markdown
Collaborator

What does this PR do?

The desktop binary detection in hermes_cli/main.py only looks for linux-unpacked/hermes (and the Hermes variant), which is the x86_64 build. On ARM64 Linux systems, the unpacked directory is named linux-arm64-unpacked instead, so the desktop app fails to find its own binary.

This PR adds linux-arm64-unpacked candidate paths to the lookup list so the desktop launch works on ARM64 Linux.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • hermes_cli/main.py: Added linux-arm64-unpacked/hermes and linux-arm64-unpacked/Hermes to the candidates list in the desktop binary detection logic

How to Test

  1. Build or download a Hermes desktop release for linux-arm64
  2. Run hermes on an ARM64 Linux machine — previously it would fail to locate the binary; after this change it finds it in linux-arm64-unpacked/
  3. Verify x86_64 desktop still works (existing linux-unpacked candidates remain first in the list)

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Linux ARM64

Documentation & Housekeeping

  • N/A — I've updated relevant documentation (README, docs/, docstrings)
  • N/A — I've updated cli-config.yaml.example if I added/changed config keys
  • N/A — I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — change is Linux-specific, no impact on other platforms
  • N/A — I've updated tool descriptions/schemas if I changed tool behavior

Screenshots / Logs

N/A

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: ethie/arm64-fix vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9780 on HEAD, 9780 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5072 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels Jun 4, 2026
@ethernet8023
ethernet8023 merged commit a6a0a5b into main Jun 4, 2026
30 of 31 checks passed
@ethernet8023
ethernet8023 deleted the ethie/arm64-fix branch June 4, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants