fix(desktop): detect linux arm64 binary - #38594
Merged
Merged
Conversation
Contributor
🔎 Lint report:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The desktop binary detection in
hermes_cli/main.pyonly looks forlinux-unpacked/hermes(and theHermesvariant), which is the x86_64 build. On ARM64 Linux systems, the unpacked directory is namedlinux-arm64-unpackedinstead, so the desktop app fails to find its own binary.This PR adds
linux-arm64-unpackedcandidate paths to the lookup list so the desktop launch works on ARM64 Linux.Related Issue
Fixes #
Type of Change
Changes Made
hermes_cli/main.py: Addedlinux-arm64-unpacked/hermesandlinux-arm64-unpacked/Hermesto thecandidateslist in the desktop binary detection logicHow to Test
linux-arm64hermeson an ARM64 Linux machine — previously it would fail to locate the binary; after this change it finds it inlinux-arm64-unpacked/linux-unpackedcandidates remain first in the list)Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings)cli-config.yaml.exampleif I added/changed config keysCONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflowsScreenshots / Logs
N/A