Skip to content

fix(discord): stop typing indicator before response delivery #38566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
njiangk wants to merge 1 commit into from
Closed

fix(discord): stop typing indicator before response delivery #38566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions gateway/platforms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4034,6 +4034,16 @@ async def _stop_typing_task() -> None:
# cancelling, let this message-processing task unwind now.
pass

async def _stop_typing_now(chat_id: str) -> None:
"""Stop the persistent typing loop *before* response delivery
so Discord's ~10s typing indicator doesn't overlap the reply."""
await _stop_typing_task()
try:
if hasattr(self, "stop_typing"):
await self.stop_typing(chat_id)
except Exception:
pass

try:
await self._run_processing_hook("on_processing_start", event)

Expand Down Expand Up @@ -4069,6 +4079,9 @@ async def _stop_typing_task() -> None:
session_key,
)
response = None
# Stop persistent typing indicator before response delivery so
# Discord's ~10s typing bubble doesn't overlap the reply text.
await _stop_typing_now(event.source.chat_id)
if not response:
logger.debug("[%s] Handler returned empty/None response for %s", self.name, event.source.chat_id)
if response:
Expand Down