fix(fallback): pass explicit base_url and api_key to resolve_provider_client - #3853
Closed
cameronbergh wants to merge 1 commit into
Closed
fix(fallback): pass explicit base_url and api_key to resolve_provider_client#3853cameronbergh wants to merge 1 commit into
cameronbergh wants to merge 1 commit into
Conversation
…_client Without these, fallback providers configured with custom endpoints (e.g. LM Studio, Ollama) fail to resolve because the router falls back to OPENAI_BASE_URL / OPENAI_API_KEY env vars instead of using the per-provider credentials from the fallback_chain config.
Contributor
|
Thanks for the contribution, @cameronbergh! Closing this as a duplicate of #2587 (by @KiraKatana), which targets the same fix/feature. We're consolidating on that PR for review. If you want to help push it over the line, please jump in there — or if you think your approach is better for a specific reason that isn't covered in the other PR, let us know and we can reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these, fallback providers configured with custom endpoints (e.g. LM Studio, Ollama) fail to resolve because the router falls back to OPENAI_BASE_URL / OPENAI_API_KEY env vars instead of using the per-provider credentials from the fallback_chain config.
Fixes the credential passthrough gap in the chain fallback mechanism from PR #3813.