Skip to content

fix(tools): wrap coroutines in create_task() in _run_async() to fix aiohttp timeout error #38525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goodtiding5 wants to merge 1 commit into from
Closed

fix(tools): wrap coroutines in create_task() in _run_async() to fix aiohttp timeout error #38525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions model_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ def _run_in_worker():
loop_ready.set()
try:
asyncio.set_event_loop(worker_loop)
return worker_loop.run_until_complete(coro)
tool_task = worker_loop.create_task(coro)
return worker_loop.run_until_complete(tool_task)
finally:
try:
# Cancel anything still pending (e.g. task cancelled
Expand Down Expand Up @@ -167,10 +168,12 @@ def _run_in_worker():
# lifetime — preventing "Event loop is closed" on GC cleanup.
if threading.current_thread() is not threading.main_thread():
worker_loop = _get_worker_loop()
return worker_loop.run_until_complete(coro)
tool_task = worker_loop.create_task(coro)
return worker_loop.run_until_complete(tool_task)

tool_loop = _get_tool_loop()
return tool_loop.run_until_complete(coro)
tool_task = tool_loop.create_task(coro)
return tool_loop.run_until_complete(tool_task)


# =============================================================================
Expand Down