fix(desktop): avoid idle chat history re-renders - #38474
Closed
hdd69 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop's parent controller can re-render while chat is idle, for example from background status polling. Before this change, those parent renders passed fresh callback props into
ChatView, rebuilt the assistant runtime adapter, and caused the mounted assistant-ui thread/chat history to re-render even when$messageshad not changed.This stabilizes the idle chat path by:
ChatViewDesktopController->ChatViewcallback propsThis is intentionally scoped to idle render isolation. It does not change the scroll-anchor logic.
Test Plan
npm run test:ui -- src/app/chat/index.test.tsxnpm run test:ui -- src/components/assistant-ui/streaming.test.tsxnpm run type-check