fix(bootstrap): re-seal installer after copying to ~/.hermes on macOS - #38446
Closed
OmarB97 wants to merge 1 commit into
Closed
fix(bootstrap): re-seal installer after copying to ~/.hermes on macOS#38446OmarB97 wants to merge 1 commit into
OmarB97 wants to merge 1 commit into
Conversation
OmarB97
force-pushed
the
fix/macos-bootstrap-reseal
branch
from
June 3, 2026 19:53
3c454d2 to
8be5cf7
Compare
alt-glitch
added
type/bug
OmarB97
force-pushed
the
fix/macos-bootstrap-reseal
branch
from
June 9, 2026 23:42
8be5cf7 to
9f3d2bb
Compare
Contributor
Author
|
Closing: upstream main now covers this — apps/bootstrap-installer/src-tauri/src/paths.rs calls repair_macos_installer_helper() right after the self-copy (xattr -cr + codesign --verify + conditional re-sign), which is strictly stronger than the unconditional re-sign here, and std::fs::copy already preserves the executable mode bits the chmod added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-cause fix for macOS in-app updater dying with exit 137. After the bootstrap installer copies itself out of the signed .app bundle, macOS amfid rejects the extracted binary because its ad-hoc signature is bound to the bundle path. This patch re-signs the copied installer immediately, allowing the updater to actually execute.