fix(installer): restore main build — pass LogStream to emit_log calls from #38296 - #38384
Merged
Merged
Conversation
PR #38296 added four emit_log() calls using the old 3-arg signature, but main had already changed emit_log to take a `stream: LogStream` argument (#38312, "stop mislabeling stdout-style progress as stderr"). The two PRs touched different lines, so the merge auto-resolved with no conflict and left main unable to compile the bootstrap installer (E0061: 4 args expected, 3 supplied). Supply the missing stream: Stdout for the update/install progress lines and Stderr for the "could not auto-launch desktop" failure, matching the convention from #38312. cargo check passes. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🔎 Lint report:
|
alt-glitch
added
type/bug
davidgut1982
pushed a commit
to davidgut1982/hermes-agent
that referenced
this pull request
Jun 5, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
…-logstream fix(installer): restore main build — pass LogStream to emit_log calls from #38296
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ler-emit-log-logstream fix(installer): restore main build — pass LogStream to emit_log calls from NousResearch#38296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maincurrently does not compile the bootstrap installer (apps/bootstrap-installer/src-tauri).PR #38296 (merged as
9632609) added fouremit_log(...)calls inupdate.rsusing the old 3-arg signature. Meanwhile #38312 ("stop mislabeling stdout-style progress as stderr",810e5864d/84710995e) had already changedemit_logto take a 4thstream: LogStreamargument. The two PRs touched different lines, so the merge of #38296 auto-resolved with no conflict — leavingmainwith the 4-arg signature and 4 stale 3-arg calls:This is the classic stale-branch-vs-recent-fix skew (the #38296 branch predated the
LogStreamchange, so it built green on the branch but breaks onmain).Changes
update.rs— supply the missingstreamarg to the 4 call sites:Stdoutfor the update/install progress lines (updating-against-branch, already-launch-target, installing-rebuilt-app)Stderrfor the "could not auto-launch desktop" failure linematching the stdout/stderr convention introduced in #38312.
Test plan
cargo checkinapps/bootstrap-installer/src-tauri— passes (only pre-existing dead-code warnings)cargo test(installer unit tests)tauri buildproduces a signed installer dmgNote
This PR is intentionally scoped to only the build break. A separate report — in-app macOS self-update relaunching the installer ("Hermes Setup") with a blank screen instead of the rebuilt Hermes desktop app — is still under investigation and not addressed here.
Made with Cursor