Fix abandoned session cleanup - #38327
Open
sean174 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for addressing retention leaks in unended session rows. The underlying gap remains on current main: pruning selects only Problems
Suggested changes
Automated hermes-sweeper review. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abandoned_cleanupbefore pruning so abandoned rows do not bypass retention foreverhermes sessions pruneand startup auto-maintenanceTest Plan
python -m pytest tests/test_hermes_state.py::TestAutoMaintenance tests/hermes_cli/test_sessions_delete.py -qpython -m pytest tests/test_hermes_state.py tests/gateway/test_session_store_prune.py tests/gateway/test_session_state_cleanup.py tests/hermes_cli/test_sessions_delete.py -qpython -m py_compile hermes_state.py hermes_cli/main.py hermes_cli/config.pygit diff --check HEAD~1..HEADNotes
This is a defensive cleanup fix for long-lived/gateway installs where sessions may remain unended after crashes, restarts, or abandoned threads. Recently active sessions are protected by checking latest message timestamp, falling back to session start time for empty sessions.