fix(codex): persist app-server session turns - #38264
Closed
sweetcornna wants to merge 1 commit into
Closed
sweetcornna wants to merge 1 commit into
sweetcornna wants to merge 1 commit into
Conversation
sweetcornna
force-pushed
the
codex/fix-38210-codex-session-persistence
branch
from
June 3, 2026 14:39
0cc01bf to
9ec3f22
Compare
Contributor
|
Closely related to (likely duplicate of) PR #38254 — both close #38210 by adding |
Contributor
Author
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversation_historyinto the Codex runtime so resume/compression skip logic stays alignedRoot cause
api_mode=codex_app_serverreturns early from the conversation loop after the Codex transport projects messages into memory. That bypassed the normal_persist_session()call, so desktop resume/session.info reconciled against an emptymessagestable and dropped the streamed reply.Closes #38210.
Verification
/Users/cornna/project/hermes-agent/.venv/bin/python -m pytest tests/run_agent/test_codex_app_server_integration.py -q/Users/cornna/project/hermes-agent/.venv/bin/python -m pytest tests/run_agent/test_860_dedup.py tests/run_agent/test_compression_persistence.py -q/Users/cornna/project/hermes-agent/.venv/bin/python -m ruff check agent/codex_runtime.py agent/conversation_loop.py run_agent.py tests/run_agent/test_codex_app_server_integration.pygit diff --check