Skip to content

fix(gateway): quiet Slack missing_scope channel directory fallback - #38137

Closed
nanckh wants to merge 1 commit into
NousResearch:mainfrom
nanckh:fix/slack-channel-directory-missing-scope-fallback
Closed

nanckh wants to merge 1 commit into
NousResearch:mainfrom
nanckh:fix/slack-channel-directory-missing-scope-fallback

Conversation

@nanckh

@nanckh nanckh commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Treat Slack users.conversations missing_scope as an expected limited-scope app condition
  • Fall back to session history without recurring gateway warnings
  • Add tests for not-ok and SlackApiError-like missing_scope responses

Test Plan

  • pytest -q tests/gateway/test_channel_directory.py

Treat Slack users.conversations missing_scope as an expected limited-scope app condition and fall back to session history without recurring warnings.

Add tests for not-ok and SlackApiError-like missing_scope responses.
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/slack Slack app adapter P2 Medium — degraded but workaround exists labels Jun 3, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the focused Slack fallback fix. Current main still emits the reported warning in gateway/channel_directory.py:242-247, and gateway/run.py:20244-20254 refreshes the directory every five minutes. The proposed handling preserves the existing session-history merge at gateway/channel_directory.py:270-276 while quieting only missing_scope responses.

Current main has since moved the Slack session fallback onto asyncio.to_thread(...) in d23990f527cbd33b528e0e107cfb3449e2f1a3fe; the conflicting change can be salvaged mechanically by retaining those awaits while applying the error classification and tests.

Automated hermes-sweeper review.

@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 14, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Merged via #70192 — your commit was cherry-picked/reapplied onto current main with your authorship preserved in git history: your missing_scope quieting was cherry-picked.

Thanks for the contribution!

@teknium1 teknium1 closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/slack Slack app adapter sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants