fix(desktop): skip Enter submit when Chinese IME is composing - #38135
Closed
Eddie0521 wants to merge 1 commit into
Closed
fix(desktop): skip Enter submit when Chinese IME is composing#38135Eddie0521 wants to merge 1 commit into
Eddie0521 wants to merge 1 commit into
Conversation
The contentEditable keydown handler checked event.key === 'Enter' but did not check event.nativeEvent.isComposing. When a Chinese IME user presses Enter to confirm the current composition candidate, the browser fires a keydown with isComposing=true; the handler treated it as submit and sent the message before the IME could finish. Add isComposing guards to both the trigger-popover Enter/Tab handler and the main Enter-to-submit handler so they return early during IME composition.
alt-glitch
added
type/bug
Collaborator
Contributor
|
Nice catch. The isComposing guard on the trigger-key handler (line 598) is the right layer -- no point processing trigger popups while the IME is still composing. Related bug #38117 is about Korean input leaving the last syllable behind in the input. The same isComposing check would fix that too if the composer still processes keydown during composition on that path. Worth checking if Korean IME also sends composition events the same way. |
Author
|
it really make some confusion. |
19 tasks
This was referenced Jun 4, 2026
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using a Chinese input method (IME), pressing Enter to confirm the current composition candidate causes the message to be sent instead — the
isComposingflag is not checked in the keydown handler.Fix
Added
event.nativeEvent.isComposingguard to both the trigger-popover Enter/Tab handler and the main Enter-to-submit handler in the contentEditable composer, so they return early during IME composition.Testing
npm run type-check✅npm run lint✅