fix(gateway): expand extract_media() extension whitelist for text/code files - #37957
Closed
mehmetkr-31 wants to merge 1 commit into
Closed
fix(gateway): expand extract_media() extension whitelist for text/code files#37957mehmetkr-31 wants to merge 1 commit into
mehmetkr-31 wants to merge 1 commit into
Conversation
…e files MEDIA: tags referencing .markdown, .py, .sh, .sql, and .log files were not whitelisted in the MEDIA_DELIVERY_EXTS tuple. For paths with spaces, the regex fell back to \S+ which truncated at the first space, silently delivering the wrong path. Add the missing extensions to MEDIA_DELIVERY_EXTS so the space-tolerant alternation branch is used for these common file types. Adds 3 new tests to TestExtractMedia including space-in-path regression.
alt-glitch
added
type/bug
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MEDIA: tags referencing .markdown, .py, .sh, .sql, and .log files were not whitelisted in the MEDIA_DELIVERY_EXTS tuple. For paths with spaces, the regex fell back to \S+ which truncated at the first space, silently delivering the wrong path.
Add the missing extensions to MEDIA_DELIVERY_EXTS so the space-tolerant alternation branch is used for these common file types.
Adds 3 new tests to TestExtractMedia including space-in-path regression.