fix(cron): clarify schedule and prompt requirements in parameter descriptions - #37859
Closed
AgatheBauer wants to merge 1 commit into
Closed
fix(cron): clarify schedule and prompt requirements in parameter descriptions#37859AgatheBauer wants to merge 1 commit into
AgatheBauer wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the targeted schema clarification. Automated hermes-sweeper review found that current
Closing as implemented on main. |
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where description-driven models (e.g., Grok) omit the required
scheduleandpromptparameters when callingcronjob(action='create').Since using the schema's root-level
requiredarray for this is not feasible (as it would reject non-create actions likelistorremoveif they omitschedule), this PR implements the maintainer-recommended targeted description update.Changes:
promptparameter description withREQUIRED for action=create (unless no_agent=True or script is set).scheduleparameter description to explicitly start withREQUIRED for action=create. You MUST always include this parameter if action=create.