Skip to content

fix(hindsight): pass retain_async=True in hindsight_retain tool handler #37838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkangg1 wants to merge 1 commit into from
Closed

fix(hindsight): pass retain_async=True in hindsight_retain tool handler #37838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/memory/hindsight/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,6 +1506,7 @@ def handle_tool_call(self, tool_name: str, args: dict, **kwargs) -> str:
content,
context=context,
tags=args.get("tags"),
retain_async=True,

@teknium1 teknium1 Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle_tool_call removes item["retain_async"] immediately before aretain_batch() (current main: :1715-1721), so this item-level value never reaches Hindsight. Pass retain_async=self._retain_async to aretain_batch(...) instead, matching the auto-retain path and preserving configured retain_async: false.

)
logger.debug("Tool hindsight_retain: bank=%s, content_len=%d, context=%s",
self._bank_id, len(content), context)
Expand Down