fix(streaming): add Slack streaming=false default to match Discord - #37688
Closed
AhmetArif0 wants to merge 1 commit into
Closed
fix(streaming): add Slack streaming=false default to match Discord#37688AhmetArif0 wants to merge 1 commit into
AhmetArif0 wants to merge 1 commit into
Conversation
PR NousResearch#37303 added per-platform streaming defaults and the commit message explicitly called out "Discord/Slack/etc. only have edit-based streaming (repeated editMessage), which flickers and is noticeably jankier" — but only discord.streaming=false was shipped. Slack uses the same edit-based streaming mechanism and has the same flicker problem, yet it was left to follow the global switch (default true when streaming is enabled). Add "slack": {"streaming": False} to DEFAULT_CONFIG["display"]["platforms"] alongside the Discord default. The same deep-merge semantics apply: a user who explicitly sets display.platforms.slack.streaming: true keeps their value unchanged. The dashboard schema gains a slack.streaming toggle automatically since it is generated from DEFAULT_CONFIG. Update test_per_platform_streaming_defaults.py to cover slack in all existing assertions and rename the resolver test to reflect both platforms.
This was referenced Jun 3, 2026
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for identifying the Slack edit-streaming parity gap. The current patch does not reach the gateway's runtime resolver.
Problems
gateway/run.py:18050resolves streaming from_load_gateway_config(), but_load_gateway_config()reads raw YAML rather than mergingDEFAULT_CONFIG(gateway/run.py:2315-2350). Therefore the newDEFAULT_CONFIG["display"]["platforms"]["slack"]entry is absent at runtime for users who have not written that setting.- With raw config, Slack inherits
_TIER_MEDIUM["streaming"] = Nonethrough_PLATFORM_DEFAULTS(gateway/display_config.py:81-89,133), so the gateway follows global streaming. The proposed test instead passes aDEFAULT_CONFIGcopy into the resolver, which does not exercise that path.
Suggested changes
- Put the built-in Slack streaming default in
gateway/display_config.py's_PLATFORM_DEFAULTS, where it applies after explicit raw-user overrides. - Test empty/raw config resolving Slack to
False, and an explicit Slacktrueoverride resolving toTrue.
This is an automated hermes-sweeper review.
| "platforms": { | ||
| "telegram": {"streaming": True}, | ||
| "discord": {"streaming": False}, | ||
| "slack": {"streaming": False}, |
Contributor
There was a problem hiding this comment.
This DEFAULT_CONFIG entry is not consumed by gateway streaming: gateway/run.py:18050 passes _load_gateway_config() to the resolver, and _load_gateway_config() reads raw YAML without merging DEFAULT_CONFIG (gateway/run.py:2315-2350). Please place the built-in Slack default in gateway/display_config.py's _PLATFORM_DEFAULTS and test the raw-config path.
Contributor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #37303 added per-platform streaming defaults and its commit message explicitly states: "Discord/Slack/etc. only have edit-based streaming (repeated
editMessage), which flickers and is noticeably jankier" — but onlydiscord.streaming=falsewas shipped. Slack uses the same edit-based streaming mechanism and has the same flicker problem, yet it was left to follow the global switch (defaults totruewhen streaming is enabled globally).Changes
hermes_cli/config.py: add"slack": {"streaming": False}toDEFAULT_CONFIG["display"]["platforms"]alongside the existing Discord default. Updated the comment to mention both Discord and Slack. The same deep-merge semantics apply: a user who explicitly setsdisplay.platforms.slack.streaming: truekeeps their value unchanged.tests/gateway/test_per_platform_streaming_defaults.py: update all existing assertions to also coverslack, rename the resolver test to reflect both platforms, and addslack.streamingto the dashboard schema exposure check.Why this is a gap-filler
Like Discord, the Slack default is a gap-filler: deep-merge means any explicit user value wins. Adding the default only affects users who have streaming globally enabled but have not explicitly overridden the Slack platform setting — exactly the set of users who would see the flickery edit-based streaming they didn't opt into.
Test plan
pytest tests/gateway/test_per_platform_streaming_defaults.py -x -q— 4 tests pass