[codex] add Fireworks provider support - #3757
Closed
chai1any wants to merge 2 commits into
Closed
Conversation
chai1any
marked this pull request as ready for review
March 29, 2026 17:43
|
does this also add the Fire Pass version of Kimi-K2.5 to the list of models that support vision? That seems to be something separate from just adding the provider. |
|
Wow, well done! I hope they'll merge this one pronto! Thank you. |
|
Hi, any progress on this? |
This was referenced Apr 24, 2026
Collaborator
1 similar comment
Collaborator
4 tasks
4 tasks
5 tasks
Contributor
|
Fireworks AI support landed via PR #62593. This contribution was part of the Fireworks provider cluster credited in the salvage PR; thank you for the implementation and review work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Hermes already supports several OpenAI-compatible providers. Fireworks uses the same integration shape, but it was missing from provider registration, setup flows, runtime/provider detection, and user-facing docs.
Impact
FIREWORKS_API_KEYorFIREWORKS_BASE_URLand run Hermes with--provider fireworksValidation
python -m pytest tests/ -q --ignore=tests/integration --tb=short -n autopython -m pytest tests/test_api_key_providers.py tests/test_runtime_provider_resolution.py tests/hermes_cli/test_model_validation.py tests/test_setup_model_selection.py tests/agent/test_models_dev.py -q --ignore=tests/integration --tb=short -n autocd website && npm cicd website && source ../.venv/bin/activate && npm run lint:diagrams && npm run build