fix(desktop): honor upward wheel scroll in long threads - #37530
Closed
ferminquant wants to merge 1 commit into
Closed
fix(desktop): honor upward wheel scroll in long threads#37530ferminquant wants to merge 1 commit into
ferminquant wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Contributor
Author
|
Closing because this PR was opened by an assistant without explicit user instruction. Apologies for the noise. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
NODE_ENV=test npm run test:ui -- src/components/assistant-ui/streaming.test.tsx -t "honors the first upward wheel scroll"(failed before fix: expected 420, received 1200)NODE_ENV=test npm run test:ui -- src/components/assistant-ui/streaming.test.tsxnpm run type-checknpx eslint src/components/assistant-ui/thread-virtualizer.tsx src/components/assistant-ui/streaming.test.tsx(0 errors; existing warnings inthread-virtualizer.tsx)Closes #37527
Notes
NODE_ENV=test npm run test:uifor the whole Desktop workspace still reports unrelated pre-existing failures: Vitest treats four Nodeelectron/*.test.cjsfiles as no-suite files, andsrc/components/pane-shell/pane-shell.test.tsxhas an unrelated widthOverride assertion failure.