Skip to content

feat(gateway): add runtime footer turn count - #37406

Open
w3rdist-creator wants to merge 1 commit into
NousResearch:mainfrom
w3rdist-creator:feat/runtime-footer-turn-count
Open

feat(gateway): add runtime footer turn count#37406
w3rdist-creator wants to merge 1 commit into
NousResearch:mainfrom
w3rdist-creator:feat/runtime-footer-turn-count

Conversation

@w3rdist-creator

Copy link
Copy Markdown

Summary

  • Adds optional runtime footer turn_count field, rendered as N/limit
  • Resolves turn_limit from global or per-platform runtime footer config, defaulting to 100
  • Passes computed gateway user-turn count into footer rendering

Test Plan

  • python -m pytest tests/gateway/test_runtime_footer.py -q -o 'addopts='

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery labels Jun 2, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused runtime-footer addition. The requested capability is still absent on current main: gateway/runtime_footer.py:105-118 recognizes only the existing three fields, and gateway/run.py:11827-11834 supplies no turn count.

Problems

  • The new config surface needs current default-config and docs coverage. hermes_cli/config.py:1922-1925 and website/docs/user-guide/configuration.md:1476-1483 list only model, context_pct, and cwd.
  • /footer on builds its preview through format_runtime_footer without a count (gateway/slash_commands.py:3073-3078), so a fields: [turn_count] configuration would produce no preview.
  • The gateway target has moved from the PR's old line 9408 to current gateway/run.py:11820-11839; this needs manual reapplication and a current-path integration test.

Suggested changes

  • Salvage the call at the current footer site, cover the final-response path, document turn_count/turn_limit, and define a preview value or omission rule for turn count.

Automated hermes-sweeper review.

Comment thread gateway/runtime_footer.py
@@ -115,6 +136,10 @@ def format_runtime_footer(
rel = _home_relative_cwd(cwd or os.environ.get("TERMINAL_CWD", ""))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also handle the /footer on preview path: it calls format_runtime_footer without turn_count (gateway/slash_commands.py:3073-3078), so configuring only this new field would render an empty preview.

@teknium1 teknium1 added sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants