Skip to content

refactor(desktop): consolidate skills + tools management into one pane - #37310

Merged
jquesnelle merged 1 commit into
mainfrom
desktop/consolidate-skills-tools-pane
Jun 2, 2026
Merged

refactor(desktop): consolidate skills + tools management into one pane#37310
jquesnelle merged 1 commit into
mainfrom
desktop/consolidate-skills-tools-pane

Conversation

@jquesnelle

Copy link
Copy Markdown
Collaborator

The left-nav Skills pane and Settings > Skills & Tools rendered the same getSkills()/getToolsets() data with the same helpers and toggles — genuine duplication that drifted (different default category labels, sort orders).

Make the left pane the single home: it keeps its category-tabbed browsing and now gains the functional bits it lacked — a real toolset enable/disable switch (was a read-only pill) and the expandable ToolsetConfigPanel for provider selection + per-key credential config. Remove the Tools section from Settings (nav item, view branch, query slot, type union entries) and delete tools-settings.tsx, migrating its toggle coverage into the skills pane test. Relabel the entry point to 'Skills & Tools' in the sidebar and command center.

The left-nav Skills pane and Settings > Skills & Tools rendered the same
getSkills()/getToolsets() data with the same helpers and toggles — genuine
duplication that drifted (different default category labels, sort orders).

Make the left pane the single home: it keeps its category-tabbed browsing
and now gains the functional bits it lacked — a real toolset enable/disable
switch (was a read-only pill) and the expandable ToolsetConfigPanel for
provider selection + per-key credential config. Remove the Tools section
from Settings (nav item, view branch, query slot, type union entries) and
delete tools-settings.tsx, migrating its toggle coverage into the skills
pane test. Relabel the entry point to 'Skills & Tools' in the sidebar and
command center.
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: desktop/consolidate-skills-tools-pane vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9647 on HEAD, 9647 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4997 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@jquesnelle
jquesnelle merged commit c6501c0 into main Jun 2, 2026
20 checks passed
@jquesnelle
jquesnelle deleted the desktop/consolidate-skills-tools-pane branch June 2, 2026 09:21
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have labels Jun 2, 2026
alt-glitch pushed a commit that referenced this pull request Jun 14, 2026
…s-tools-pane

refactor(desktop): consolidate skills + tools management into one pane
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
…lidate-skills-tools-pane

refactor(desktop): consolidate skills + tools management into one pane
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…lidate-skills-tools-pane

refactor(desktop): consolidate skills + tools management into one pane
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…lidate-skills-tools-pane

refactor(desktop): consolidate skills + tools management into one pane
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…lidate-skills-tools-pane

refactor(desktop): consolidate skills + tools management into one pane
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…lidate-skills-tools-pane

refactor(desktop): consolidate skills + tools management into one pane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants