docs(kanban): RFC task-scoped skill injection - #37304
Draft
hehehe0803 wants to merge 1 commit into
Draft
Conversation
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for documenting the broader overlay design. The RFC remains useful, but its baseline needs an update before it can serve as a reliable developer guide.
Problems
website/docs/developer-guide/kanban-task-scoped-skill-injection.md:46and:171describe a spawned--skills kanban-worker. Current dispatch forwards only declared task skills (hermes_cli/kanban_db.py:8031-8039); the current regression test explicitly says no skill is auto-loaded (tests/hermes_cli/test_kanban_core_functionality.py:3043-3079).website/docs/developer-guide/kanban-task-scoped-skill-injection.md:48says missing required skills fail at startup. Current CLI skips missing names when at least one requested skill loads, and raises only when all are missing (cli.py:15931-15947).
Suggested changes
- Refresh the current-state comparison and label fail-closed handling as proposed RFC behavior, not current behavior.
Automated hermes-sweeper review.
|
|
||
| 1. Dispatcher claims a Kanban task. | ||
| 2. Dispatcher resolves the assignee profile home. | ||
| 3. Dispatcher builds a child command like `hermes -p <profile> --skills kanban-worker --skills <task-skill> chat -q "work kanban task <id>"`. |
Contributor
There was a problem hiding this comment.
This is stale against current main: _default_spawn() forwards only task.skills (hermes_cli/kanban_db.py:8031-8039), and tests/hermes_cli/test_kanban_core_functionality.py:3043-3079 explicitly asserts no skill is auto-loaded. Please remove kanban-worker from the current-state command and explain that lifecycle guidance is injected separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task.skillsshould preflight against profile-local roots plus approved read-only task overlay roots.optional_skillssemantics.Relationship to existing work
Test plan
cd website && npm run buildweb-dashboardand zh-Hans docs; no new failure from this RFC page.