fix(cli): prevent crash on Linux runtimes lacking systemctl - #3727
Closed
devorun wants to merge 1 commit into
Closed
fix(cli): prevent crash on Linux runtimes lacking systemctl#3727devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
Contributor
|
Closing as duplicate — this issue is fixed in #8614 (salvaged from @alt-glitch's comprehensive #8573). Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3724
Root Cause:
When running
hermes statuson minimal Linux distributions, Docker containers, WSL, or custom setups (like CatchyOS) that lacksystemd, the CLI crashes with an unhandledFileNotFoundError. The code previously assumedsystemctlwas always available in the PATH ifsys.platform.startswith('linux')evaluated toTrue.Fix:
Updated the status check logic in
hermes_cli/status.pyto useshutil.which("systemctl")before attempting to spawn the subprocess.systemctlexists, the status check proceeds normally.systemdis unavailable in the current runtime, preventing the crash.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs