fix: decode SSH subprocess output tolerantly

[honor2030]

⚠️ Superseded — please do not merge

This PR is obsolete and is being closed. The subprocess text-decoding bug class, including the SSH call sites changed here, landed on main through #70875.

Why this PR is being closed

• fix(windows): close out the text-mode subprocess decode bug class — salvage #55339/#60741/#60751 + full sweep + linter #70875 completed a repository-wide text=True subprocess sweep and added a CI linter against regressions.
• tools/environments/ssh.py is included in that merged scope.
• This branch is now conflicting with current main; rebasing it would duplicate the merged implementation.

Where the maintained change lives

• Replacement: fix(windows): close out the text-mode subprocess decode bug class — salvage #55339/#60741/#60751 + full sweep + linter #70875
• Merge commit: 0f732cb3d6b11dc903ca4303ef2cabd99cbe0adc
• Relevant sweep commit: f8dde9aa89b55e4c5d0b7ecb35f1ea1570f9f0e4

Closing this PR unmerged. The branch is left intact for reference.

[teknium1]

Thanks for the focused fix. The reported initialization failure is still present on current main: tools/environments/ssh.py:149 (and six sibling direct calls) uses text=True with captured output but no tolerant decoding.

Problems

• tests/tools/test_ssh_environment_decoding.py:31 depends on the old one-line call layout. Current main formats every relevant call across multiple lines, such as tools/environments/ssh.py:104-110 and 149-155, so this scan would produce no snippets after salvage even if the implementation is correct.
• The direct subprocess.run scope leaves SSHEnvironment._run_bash (tools/environments/ssh.py:353) delegating to _popen_bash, whose Popen(..., text=True) at tools/environments/base.py:146-152 still has no encoding/error parameters. Please explicitly decide whether that execution path belongs in this bug class.

Suggested changes

• Apply the seven kwargs changes to the current multiline calls and replace the source-layout assertion with behavior-oriented subprocess tests.
• If execution output is in scope, cover _popen_bash; otherwise narrow the stated guarantee to direct SSH/scp setup and sync calls.

Automated hermes-sweeper review.

[teknium1]

This only recognizes one-line subprocess.run(..., capture_output=True, text=True) calls. Current main formats all seven relevant SSH calls across multiple lines, so this test would find no snippets after salvage even when the decoding kwargs are present. Please use a behavior-oriented test or a layout-independent inspection.

[honor2030]

Closing as superseded by merged #70875. That PR covers the SSH subprocess decoding sites and adds repository-wide enforcement. This branch remains intact for reference.