Skip to content

fix(auth): share xai oauth state across profiles - #37243

Closed
thunderfight127-svg wants to merge 1 commit into
NousResearch:mainfrom
thunderfight127-svg:fix/xai-oauth-shared-store
Closed

fix(auth): share xai oauth state across profiles#37243
thunderfight127-svg wants to merge 1 commit into
NousResearch:mainfrom
thunderfight127-svg:fix/xai-oauth-shared-store

Conversation

@thunderfight127-svg

Copy link
Copy Markdown

Summary

  • add a shared xAI OAuth token store for named Hermes profiles
  • route xAI OAuth reads, writes, refreshes, and credential-pool singleton sync through the shared store
  • keep classic single-home auth.json behavior compatible and document the named-profile behavior

Test plan

  • git diff --check
  • python -m py_compile hermes_cli/auth.py agent/credential_pool.py
  • .venv/bin/python -m pytest tests/hermes_cli/test_auth_xai_oauth_provider.py tests/agent/test_credential_pool.py tests/agent/test_credential_pool_routing.py tests/tools/test_credential_pool_env_fallback.py -q -o 'addopts='

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have area/auth Authentication, OAuth, credential pools provider/xai xAI (Grok) labels Jun 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This overlaps heavily with #28375 (fix(auth): share xAI OAuth refresh across profiles), which takes the same approach (shared root auth store + dedicated xAI OAuth lock + credential_pool sync) and is broader in scope. #33284 was already closed as a duplicate of #28375. Suggest consolidating on #28375.

@thunderfight127-svg

Copy link
Copy Markdown
Author

Thanks for pointing this out. Confirmed this overlaps with #28375, and #28375 is the better consolidation target since it is broader and already covers the shared xAI OAuth refresh path plus credential_pool/docs. I’ll close this PR as a duplicate rather than split reviewer attention. If any smaller test/doc cleanup from this branch is still useful, I can propose it against #28375 separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools P3 Low — cosmetic, nice to have provider/xai xAI (Grok) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants