Skip to content

fix(minimax): ignore M3 models.dev context underreport - #37235

Closed
mark202 wants to merge 1 commit into
NousResearch:mainfrom
mark202:fix/minimax-m3-context-cache
Closed

fix(minimax): ignore M3 models.dev context underreport#37235
mark202 wants to merge 1 commit into
NousResearch:mainfrom
mark202:fix/minimax-m3-context-cache

Conversation

@mark202

@mark202 mark202 commented Jun 2, 2026

Copy link
Copy Markdown

Summary

  • reject models.dev's 512K underreport for MiniMax-M3
  • fall through to the hardcoded 1M MiniMax-M3 context default after stale cache invalidation

Test Plan

  • python -m pytest tests/agent/test_minimax_provider.py::TestMinimaxM3StaleCacheGuard::test_stale_m3_cache_dropped_and_reresolves_to_1m -q
  • python -m pytest tests/agent/test_minimax_provider.py -q
  • python -m pytest tests/agent/test_model_metadata.py tests/agent/test_models_dev.py tests/agent/test_minimax_provider.py -q
  • python -m ruff check agent/model_metadata.py tests/agent/test_minimax_provider.py
  • python -m ty check agent/model_metadata.py

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint provider/minimax MiniMax (Anthropic transport) labels Jun 2, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused MiniMax-M3 investigation. This is an automated hermes-sweeper review; current main already provides the requested guarantee.

  • 5a4297a11a83c38ac24eec7df0e4e41d6b3dbb9f (fix(model_metadata): prefer hardcoded 1M for MiniMax M3 over stale models.dev probe) is on main and shipped in v2026.6.19.
  • agent/model_metadata.py:2375-2384 detects MiniMax-M3, rejects a models.dev value below the hardcoded catalog value, and returns that 1M catalog value.
  • agent/model_metadata.py:281-287 defines minimax-m3 as 1_000_000, ahead of the generic MiniMax fallback.

Closing as implemented on main.

@teknium1 teknium1 closed this Jul 13, 2026
@teknium1 teknium1 added sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants