[Hermes Agent][hermes-pr35642-split-snowball][1/n] Split dflash canary hardening loop - #37160
Closed
OmarB97 wants to merge 7 commits into
Closed
[Hermes Agent][hermes-pr35642-split-snowball][1/n] Split dflash canary hardening loop#37160OmarB97 wants to merge 7 commits into
OmarB97 wants to merge 7 commits into
Conversation
added 7 commits
June 1, 2026 19:55
This was referenced Jun 2, 2026
OmarB97
marked this pull request as ready for review
June 2, 2026 03:26
Contributor
Author
|
Closing: the canary/hardening loop shells out to MeshBoard tooling (.mesh/tools/meshctl.py and --meshboard-* flags) that doesn't exist for upstream users, so this belongs in our own tooling repo rather than upstream. The one upstream-generic piece — opt-in faulthandler/SIGUSR1 thread-dump diagnostics for oneshot — will be resubmitted standalone as a small feat(cli) PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes -zdflash workflows and writes JSONL evidence.Why
#35642 grew into a multi-feature recovery stack. This PR is the measurement/ownership slice only, so it can be reviewed independently from the behavior-changing stall-retry and local-backend failover changes.
Validation
scripts/run_tests.sh tests/scripts/test_dflash_stability_canary.pypython3 scripts/check-windows-footguns.py scripts/dflash_stability_canary.py scripts/dflash_hardening_loop.py hermes_cli/oneshot.py tests/scripts/test_dflash_stability_canary.pypython3 -m py_compile scripts/dflash_stability_canary.py scripts/dflash_hardening_loop.py hermes_cli/oneshot.py tests/scripts/test_dflash_stability_canary.pygit -c core.fsmonitor=false diff --check upstream/main..HEADRelationship To Existing PRs
Split from #35642. This PR intentionally does not include the stall-retry policy changes, local first-chunk failover, or local backend recovery hook.