-
Notifications
You must be signed in to change notification settings - Fork 52.9k
expose Location, X-Request-Id, Idempotency-Key via CORS #3707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+31
−1
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b297b60
feat(api-server): expose Location, X-Request-Id, Idempotency-Key via …
aydnOktay 6ea3792
test(api-server): assert Access-Control-Expose-Headers present for CORS
aydnOktay 4d7cd4a
fix(skills): always surface remote environment reminder; show setup_n…
aydnOktay 79700ce
fix(skills): keep skill_view JSON free of setup_note after local capt…
aydnOktay 7243deb
fix(skills): synthesize remote setup note in _build_skill_message; re…
aydnOktay e59f0c4
fix(skills): track loaded skill names in preloaded prompt builder
aydnOktay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This skill-message behavior is unrelated to the PR's stated API-server CORS change. Please keep the CORS salvage focused on
gateway/platforms/api_server.pyand its test; the mixed scope is what leaves this aggregate branch conflicting.