support dashboard websocket attach on Node 20 - #37030
Closed
PAW122 wants to merge 1 commit into
Closed
Conversation
Fix embedded dashboard TUI failures when the PTY process runs under Node 20, where global WebSocket may be unavailable. Fall back to undici's WebSocket constructor and cover the attach-mode behavior in gateway client tests. Also keeps the prior render-phase update fix for gateway event handler creation, preventing eager config RPC during React render.
Contributor
|
Thanks for the focused dashboard/TUI investigation. This is an automated hermes-sweeper review; the requested behavior is already present on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two dashboard-embedded TUI failures: