fix(skills): ignore asset markdown in skill_view collision scan - #36895
Closed
worlldz wants to merge 1 commit into
Closed
fix(skills): ignore asset markdown in skill_view collision scan#36895worlldz wants to merge 1 commit into
worlldz wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the focused regression case. This is already implemented on current Automated hermes-sweeper review:
The timeline cross-reference to PR #37164 identified the same root cause. Closing as implemented on main. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35745
skill_viewwas treating nested legacy*.mdfiles under another directory skill (for exampleassets/shared-name.md) as bare-name skill candidates.That caused false collision reports even when there was only one real skill with the requested name.
This patch keeps the existing collision protection for actual same-name skills, but ignores linked markdown files nested under directory skills when scanning legacy flat skill files.
Validation:
uv run --extra dev pytest tests/tools/test_skills_tool.py -q -k 'asset_markdown_name_does_not_trigger_false_collision or TestSkillViewCollisionDetection'Result:
7 passed, 80 deselected