Skip to content

fix: skip OpenAI rebuild for anthropic clients - #36832

Closed
pranjalbhatia710 wants to merge 1 commit into
NousResearch:mainfrom
pranjalbhatia710:fix/anthropic-rebuild-noop
Closed

fix: skip OpenAI rebuild for anthropic clients#36832
pranjalbhatia710 wants to merge 1 commit into
NousResearch:mainfrom
pranjalbhatia710:fix/anthropic-rebuild-noop

Conversation

@pranjalbhatia710

Copy link
Copy Markdown

Summary

  • Skip shared OpenAI client rebuilds for native anthropic_messages clients
  • Add regression coverage so Bedrock/Anthropic native paths do not try to create an OpenAI client during stale-stream cleanup

Validation

  • ./scripts/run_tests.sh tests/run_agent/test_run_agent.py
  • git diff --check

Fixes #36693

@mxnstrexgl mxnstrexgl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated PR Review

Security Scan

  • ✓ No hardcoded secrets, injection sinks, unsafe deserialization, or dependency red flags found by this automated scan.

Code Quality

  • ✓ No blocking code-quality issues found by this automated scan.

Summary

Status: APPROVE — security findings: 0, quality suggestions: 0.

Automated review; raw diff content intentionally omitted.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint provider/anthropic Anthropic native Messages API provider/bedrock AWS Bedrock (boto3, IAM) labels Jun 1, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #36719 and #36714 — all three fix #36693 (stale-stream watchdog rebuilding the OpenAI client for anthropic_messages/Bedrock). Also overlaps the broader stream-cleanup PRs #28240/#33855. Maintainers should pick one canonical fix.

@pranjalbhatia710

Copy link
Copy Markdown
Author

Thanks for flagging this. Agree that this overlaps the other stale-stream watchdog fixes for #36693. I’ll leave this PR as a narrow candidate, but I’m fine with maintainers picking the earliest/canonical branch and closing this one if that keeps the queue cleaner.

@pranjalbhatia710

Copy link
Copy Markdown
Author

Closing this to reduce maintainer queue noise after the duplicate/consolidation note above. Thanks for pointing me to the earlier canonical PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists provider/anthropic Anthropic native Messages API provider/bedrock AWS Bedrock (boto3, IAM) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bedrock provider: stale-stream client rebuild logs misleading "OPENAI_API_KEY missing" warning

3 participants