fix(scripts): add explicit utf-8 encoding to read_text/write_text calls (fixes #36649) - #36828
fix(scripts): add explicit utf-8 encoding to read_text/write_text calls (fixes #36649)#36828Morad37 wants to merge 1 commit into
Conversation
mxnstrexgl
left a comment
There was a problem hiding this comment.
🤖 Automated PR Review
Security Scan
- ✓ No hardcoded secrets, injection sinks, unsafe deserialization, or dependency red flags found by this automated scan.
Code Quality
- ✓ No blocking code-quality issues found by this automated scan.
- ℹ️ No test file changes detected; verify existing coverage exercises this behavior.
Summary
Status: APPROVE — security findings: 0, quality suggestions: 0.
Automated review; raw diff content intentionally omitted.
|
Thanks for the focused fix. The premise remains valid on current main: the five targeted calls are still bare at Current main has moved since the PR base and GitHub reports the branch as conflict-dirty, so this should be salvaged by reapplying the same five substitutions to HEAD rather than merging the stale branch directly. Automated hermes-sweeper review. |
|
Closing as resolved by PR #71078 (merged, commit d372fda), which retired the bare read_text/write_text class codebase-wide: 139 sites guarded (11 contributor PRs salvaged with authorship preserved — earliest submitters credited — plus an AST sweep), with a CI linter rule and AST guard test preventing regressions. Every site this PR touches is guarded on current main — verified per-site before closing. Thanks for the fix; the number of independent PRs on this class is what escalated it to the campaign. |
Adds encoding=utf-8 to 5 read_text/write_text calls in:
The project enables Ruff rule PLW1514 globally, but these calls were missing the encoding parameter. All other calls in these files already had explicit encoding.