Skip to content

fix(completion): replace 'ls' with glob-based listing in generated scripts #36806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyssta-exe wants to merge 1 commit into from
+5 −3
Closed

fix(completion): replace 'ls' with glob-based listing in generated scripts #36806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions hermes_cli/completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def generate_bash(parser: argparse.ArgumentParser) -> str:
local profiles_dir="$HOME/.hermes/profiles"
local profiles="default"
if [ -d "$profiles_dir" ]; then
profiles="$profiles $(ls "$profiles_dir" 2>/dev/null)"
for f in "$profiles_dir"/*/; do [ -d "$f" ] && profiles="$profiles $(basename "$f")"; done
fi
echo "$profiles"
}}
Expand Down Expand Up @@ -206,7 +206,7 @@ def generate_zsh(parser: argparse.ArgumentParser) -> str:
local -a profiles
profiles=(default)
if [[ -d "$HOME/.hermes/profiles" ]]; then
profiles+=("${{(@f)$(ls $HOME/.hermes/profiles 2>/dev/null)}}")
for f in $HOME/.hermes/profiles/*(N/); do profiles+=("${f:t}"); done
fi
_describe 'profile' profiles
}}
Expand Down Expand Up @@ -260,7 +260,9 @@ def generate_fish(parser: argparse.ArgumentParser) -> str:
"function __hermes_profiles",
" echo default",
" if test -d $HOME/.hermes/profiles",
" ls $HOME/.hermes/profiles 2>/dev/null",
" for d in $HOME/.hermes/profiles/*/
basename $d
end",
" end",
"end",
"",
Expand Down