Skip to content

fix(acp): pass fallback_providers to AIAgent in editor integrations (… #36720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ericcc-Ma wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix(acp): pass fallback_providers to AIAgent in editor integrations (… #36720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions acp_adapter/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,11 @@ def _make_agent(
"session_id": session_id,
"session_db": self._get_db(),
"model": model or default_model,
"fallback_model": (

@teknium1 teknium1 Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model_cfg is config.get("model"), but fallback configuration is top-level. This will remain None for normal fallback_providers: config; use the full config with get_fallback_chain(config) instead.

(model_cfg.get("fallback_providers") or model_cfg.get("fallback_model"))
if isinstance(model_cfg, dict)
else None
),
}

try:
Expand Down