fix: quiet Slack control flow - #36670
Conversation
|
Vucar staging is already patched and restarted (Hermes gateway PID 1231745). Targeted staging tests passed: |
|
Thanks for the Slack security and delivery-focused work. The approval-button authorization issue is already resolved on current main by commit Problems
Suggested changes
Automated hermes-sweeper review. |
|
Merged via #70192 — your commit was cherry-picked/reapplied onto current main with your authorship preserved in git history: your control-flow quieting was salvaged. Thanks for the contribution! |
Summary
SLACK_ALLOWED_USERS,GATEWAY_ALLOWED_USERS, and paired-user store used for normal messagesGatewayRunnerto the Slack adapter so paired Slack users can approve actions from buttonsRoot Cause
Slack button interactions bypass the normal message authorization path in
gateway/run.py. That meant a user who was paired/authorized for Slack messages could still fail approval-button flows, and the gateway could post implementation-status noise into shared Slack channels.Validation
python -m py_compile gateway/platforms/slack.py gateway/run.py tests/gateway/test_slack_approval_buttons.py tests/gateway/test_busy_session_ack.pypython -m pytest tests/gateway/test_slack_approval_buttons.py tests/gateway/test_busy_session_ack.py -q(46 passed)git diff --check