fix(tools): split concatenated streamed tool-call args - #36207
Closed
Jamesvagabond599 wants to merge 1 commit into
Closed
fix(tools): split concatenated streamed tool-call args#36207Jamesvagabond599 wants to merge 1 commit into
Jamesvagabond599 wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #36039 and #25346 — same fix: splitting concatenated streamed tool-call argument payloads ( |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes streamed tool-call handling when a model emits multiple concatenated JSON tool-call argument payloads in one streamed argument buffer.
The repair splits adjacent complete JSON object payloads before reconstructing streamed mock tool calls, preventing concatenated tool-call arguments from being treated as a single invalid JSON blob.
Related Issue
Fixes tool-call argument streaming failures observed with local Hermes/Qwen-style runtime usage.
Fixes #
Type of Change
Changes Made
_split_concatenated_tool_call_arguments(...)handling inagent/chat_completion_helpers.py.mock_tool_callsreconstruction.tests/test_model_tools_tool_call_payload_repair.py.How to Test
./venv/bin/python -m pytest -q tests/test_model_tools_tool_call_payload_repair.py3 passed.agent/chat_completion_helpers.pytests/test_model_tools_tool_call_payload_repair.pyChecklist
Code
fix(scope): ...)pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/AFor New Skills
[x] N/A — this PR does not add a skill
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs