Skip to content

feat(discord): register /approve and /deny as native Discord slash commands - #3620

Closed
ygd58 wants to merge 1 commit into
NousResearch:mainfrom
ygd58:feat/discord-approve-deny-slash-commands
Closed

feat(discord): register /approve and /deny as native Discord slash commands#3620
ygd58 wants to merge 1 commit into
NousResearch:mainfrom
ygd58:feat/discord-approve-deny-slash-commands

Conversation

@ygd58

@ygd58 ygd58 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #3614

Problem

/approve and /deny were missing from Discord's native slash command registry. In multi-bot servers, Discord routes slash interactions to whichever bot has the command registered — without registration, another bot wins and Hermes never sees the approval.

Fix

Added /approve and /deny slash command handlers using the existing _run_simple_slash helper, consistent with all other Hermes Discord slash commands.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution @ygd58! This fix was independently implemented and merged in PR #4800 (commit aecbf7fa4) about a week after your PR was opened.

Evidence:

Closing as already implemented. This is an automated hermes-sweeper review.

@teknium1 teknium1 closed this Apr 27, 2026
@alt-glitch alt-glitch added type/feature New feature or request P2 Medium — degraded but workaround exists platform/discord Discord bot adapter comp/gateway Gateway runner, session dispatch, delivery labels Apr 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Superseded by #4800 — merged PR with /approve /deny slash commands and button-based approval UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/discord Discord bot adapter type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Discord slash commands for /approve and /deny

3 participants