feat(discord): register /approve and /deny as native Discord slash commands - #3620
Closed
ygd58 wants to merge 1 commit into
Closed
feat(discord): register /approve and /deny as native Discord slash commands#3620ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the contribution @ygd58! This fix was independently implemented and merged in PR #4800 (commit Evidence:
Closing as already implemented. This is an automated hermes-sweeper review. |
Collaborator
|
Superseded by #4800 — merged PR with /approve /deny slash commands and button-based approval UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3614
Problem
/approve and /deny were missing from Discord's native slash command registry. In multi-bot servers, Discord routes slash interactions to whichever bot has the command registered — without registration, another bot wins and Hermes never sees the approval.
Fix
Added /approve and /deny slash command handlers using the existing _run_simple_slash helper, consistent with all other Hermes Discord slash commands.