fix(discord): keep clarify prompts visible when embeds are hidden

[carltonawong]

Summary

Discord web/mobile can render the component buttons for an embed-backed prompt while hiding the embed body itself. That leaves send_clarify() prompts in a dangerous state: the user can see the choices, but not the question/draft text they are choosing about.

This adds a narrow defensive fallback for Discord send_clarify() only: the critical prompt body is also sent as normal message.content, while preserving the existing embed and button view.

Related: #33681

Changes

• plugins/platforms/discord/adapter.py
  • adds visible normal-message content for Discord clarify prompts
  • keeps the existing embed + button UX intact
  • truncates the visible fallback at Discord's 2000-character content limit with an explicit warning not to approve unless the full prompt/draft is visible elsewhere
• tests/gateway/test_discord_clarify_buttons.py
  • updates the clarify send regression to assert the prompt/draft text is present in normal message content alongside the embed and view

Scope

This intentionally covers only send_clarify().

Issue #33681 notes the same Discord embed+components rendering class may affect send_exec_approval, send_slash_confirm, send_update_prompt, the model picker, and free-response cards. Those are left for a follow-up so this PR stays small and reviewable.

The reason to start with clarify is that clarify prompts can contain draft/approval text where choosing a button without seeing the body is unsafe.

Validation

• python -m pytest -o addopts='' tests/gateway/test_discord_clarify_buttons.py -q → 14 passed
• python -m py_compile plugins/platforms/discord/adapter.py tests/gateway/test_discord_clarify_buttons.py
• git diff --check
• Live Discord smoke test on a running gateway: clarify buttons rendered and the prompt/draft body was visible in normal message content above the buttons.

[mxnstrexgl]

LGTM — automated review passed. No security, quality, or test coverage issues detected.

[carltonawong]

Refreshed this branch on top of current main.

The PR is still intentionally narrow: it only changes the Discord send_clarify() send path, preserving the existing embed + button UX while adding normal message.content as a defensive visibility fallback for the critical prompt/draft body.

Validated after rebasing:

python -m pytest -o addopts='' tests/gateway/test_discord_clarify_buttons.py -q
python -m py_compile plugins/platforms/discord/adapter.py tests/gateway/test_discord_clarify_buttons.py
git diff --check origin/main...HEAD

Results:

• 14 passed
• py_compile ok
• diff check ok

Would appreciate a maintainer review when someone has bandwidth. I think this is complementary to #33681 because it covers the safety-critical clarify case where Discord renders buttons but hides the embed body the user needs before choosing.

[carltonawong]

Refreshed this branch on top of current main.

I also re-checked the related GitHub/source context before pushing:

• Discord approval embed not rendering on web/mobile — embed data present in API but invisible #33681 is still open.
• The only PR I found referencing Discord approval embed not rendering on web/mobile — embed data present in API but invisible #33681 is this one.
• Current origin/main still sends Discord send_clarify() as embed-only, so the clarify prompt body can still be hidden if Discord renders the components but not the embed body.
• I did not find another merged/open PR that adds this send_clarify() message.content fallback.

The rebase conflict was only around current send_clarify() storing view._message; the refreshed branch keeps that behavior while adding the visible content fallback.

Validated after rebasing:

python -m pytest -o addopts='' tests/gateway/test_discord_clarify_buttons.py -q
python -m py_compile plugins/platforms/discord/adapter.py tests/gateway/test_discord_clarify_buttons.py
git diff --check origin/main...HEAD

Results:

• 14 passed
• py_compile ok
• diff check ok

I also reran the prior red tests/hermes_cli/test_gui_command.py file locally; it still fails in my local environment due missing pathspec / desktop hash tests, which appears unrelated to this Discord clarify diff.

[teknium1]

Thanks for the focused safety fallback. This is now implemented on current main by a broader Discord prompt-visibility fix.

• Automated hermes-sweeper review verified plugins/platforms/discord/adapter.py:5816-5827: send_clarify() constructs normal content from the question and sends it alongside the existing embed and button view.
• Commit 009b42d008b81c18af39414dded9ecdf06082d93 (fix(discord): mirror all interactive prompt payloads into message content) added this behavior and retained the embed as progressive enhancement.
• tests/gateway/test_discord_prompt_content_siblings.py:69-104 covers both choice and open-ended clarify content fallbacks.
• The implementation is contained in tag v2026.7.7.

Closing as implemented on main.