fix(google-chat): allow http inbound without pubsub - #36035
Closed
aeyeopsdev wants to merge 1 commit into
Closed
Conversation
This was referenced May 31, 2026
aeyeopsdev
marked this pull request as ready for review
May 31, 2026 21:07
aeyeopsdev
force-pushed
the
fix/google-chat-http-inbound-mode
branch
from
June 30, 2026 12:20
2514313 to
a6af316
Compare
aeyeopsdev
force-pushed
the
fix/google-chat-http-inbound-mode
branch
from
July 5, 2026 23:27
a6af316 to
c8c7c0b
Compare
Contributor
|
Thanks for separating the Pub/Sub configuration work from the follow-up callback work. The Pub/Sub-only limitation is present on current main, but this slice is not operational by itself. Problems
Suggested changes
Automated hermes-sweeper review. |
This was referenced Jul 16, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows the bundled Google Chat platform plugin to be configured for authenticated HTTP inbound callbacks without requiring a Cloud Pub/Sub pull subscription.
This reduces Google Chat setup friction by letting the plugin use either supported inbound transport instead of forcing every deployment through Pub/Sub.
Pub/Sub remains supported for no-public-URL deployments. This only makes the inbound transport optional when an HTTP callback URL is configured.
Related Issue
N/A — small setup/connectivity improvement for the pluginized Google Chat adapter.
Type of Change
Changes Made
plugins/platforms/google_chat/adapter.py: accepthttp_events_urlas a valid inbound mode.plugins/platforms/google_chat/adapter.py: keep Pub/Sub validation/supervisor startup only when a subscription is configured.plugins/platforms/google_chat/plugin.yaml: make Pub/Sub project/subscription optional and surfaceGOOGLE_CHAT_HTTP_EVENTS_URL.tests/gateway/test_google_chat.py: cover env enablement, config validation, project inference, and connect behavior for HTTP inbound mode.How to Test
scripts/run_tests.sh tests/gateway/test_google_chat.pypython /root/.codex/skills/hermes-upstream-pr/scripts/pr_preflight.py --base upstream/mainChecklist
Code
Documentation & Housekeeping
cli-config.yaml.exampleupdate N/A.CONTRIBUTING.md/AGENTS.mdupdate N/A.Related PRs
Screenshots / Logs
Validation passed locally: