Skip to content

fix(tools): scope google chat toolset to platform #36027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aeyeopsdev wants to merge 2 commits into from
Closed

fix(tools): scope google chat toolset to platform #36027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d74d0c
fix(tools): scope google chat toolset to platform
aeyeopsdev May 31, 2026
c8f440b
style(google-chat): single blank line between tests (E303)
aeyeopsdev Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hermes_cli/tools_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ def _xai_credentials_present() -> bool:
_TOOLSET_PLATFORM_RESTRICTIONS: Dict[str, Set[str]] = {
"discord": {"discord"},
"discord_admin": {"discord"},
"google_chat": {"google_chat"},

@teknium1 teknium1 Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google_chat is currently a platform adapter, not a plugin toolset: plugins/platforms/google_chat/adapter.py:3290 calls register_platform, and get_plugin_toolsets() derives entries only from registered tools (hermes_cli/plugins.py:2422-2462). This restriction has no runtime target until Google Chat-specific model tools are registered.

}


Expand Down Expand Up @@ -1800,6 +1801,8 @@ def _get_platform_tools(
known_map = config.get("known_plugin_toolsets", {})
known_for_platform = set(known_map.get(platform, []))
for pts in plugin_ts_keys:
if not _toolset_allowed_for_platform(pts, platform):
continue
if pts in toolset_names:
# Explicitly listed in config — enabled
enabled_toolsets.add(pts)
Expand Down
16 changes: 16 additions & 0 deletions tests/hermes_cli/test_tools_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,6 +1316,15 @@ def test_discord_toolsets_not_available_on_other_platforms():
assert _toolset_allowed_for_platform("discord_admin", "discord")


def test_google_chat_toolset_not_available_on_other_platforms():
from hermes_cli.tools_config import _toolset_allowed_for_platform

for plat in ["cli", "telegram", "discord", "slack", "whatsapp", "signal"]:
assert not _toolset_allowed_for_platform("google_chat", plat), (
f"`google_chat` toolset leaked onto {plat}"
)
assert _toolset_allowed_for_platform("google_chat", "google_chat")

def test_discord_toolsets_user_enabled_are_honored():
"""When the user opts in via `hermes tools`, the toolset appears."""
config = {"platform_toolsets": {"discord": ["web", "terminal", "discord"]}}
Expand All @@ -1337,6 +1346,13 @@ def test_save_platform_tools_strips_restricted_toolsets():
assert "terminal" in saved


def test_save_platform_tools_strips_google_chat_toolset_from_non_google_chat():
config = {}
_save_platform_tools(config, "telegram", {"web", "google_chat"})
saved = config["platform_toolsets"]["telegram"]
assert "google_chat" not in saved
assert "web" in saved

def test_get_platform_tools_feishu_includes_doc_and_drive():
enabled = _get_platform_tools({}, "feishu")
assert "feishu_doc" in enabled
Expand Down