fix: preserve user focus after todo compression - #35349
Closed
ykq wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Related: This competes with #26981 and #18883, all addressing #26979 (todo snapshot injected as synthetic user message after compression). This PR takes the approach of prepending the snapshot into the latest real user turn rather than removing the injection entirely (#26981) or stripping subjects (#18883). Maintainers should pick one approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usermessage.Test plan
./venv/bin/python -m pytest -o addopts='' tests/agent/test_compression_todo_injection.py tests/tools/test_todo_tool.py -q→ 17 passed./venv/bin/python -m pytest -o addopts='' tests/agent/test_context_compressor.py tests/agent/test_context_compressor_summary_continuity.py tests/run_agent/test_compression_boundary.py tests/agent/test_compression_todo_injection.py tests/tools/test_todo_tool.py -q→ 108 passedNotes
This fixes a compression-focus regression where internal continuity state could be interpreted as the newest user request after compaction.