fix(skill_manager): follow symlinks when discovering skills (#35184)

[Linux2010]

What broke

_find_skill() and _find_skill_in_other_profiles() in tools/skill_manager_tool.py used Path.rglob("SKILL.md") to discover skills. Python's pathlib.rglob() does NOT follow symbolic links into directories. This caused skill_manage to fail with "Skill not found in active profile" for any skill located under a symlinked category directory.

Meanwhile, prompt_builder.py uses iter_skill_index_files() → os.walk(followlinks=True), which DOES follow symlinks. This inconsistency meant skills appeared in the system prompt index but could not be managed via skill_manage.

Root cause

rglob() does not follow symlinks by design. The two discovery paths (skill_manager_tool.py vs prompt_builder.py) used different mechanisms, and the rglob path missed symlinked skills.

Why this fix is minimal

Replaces rglob("SKILL.md") with iter_skill_index_files(skills_dir, "SKILL.md") from agent.skill_utils, which already uses os.walk(followlinks=True) and handles EXCLUDED_SKILL_DIRS filtering. Only two call sites changed; no new dependencies or behavioral changes.

What I tested

Added TestFindSkillSymlinks class with two tests:

• test_symlinked_skill_dir_is_found — verifies a skill under a symlinked category directory is discovered
• test_nested_symlinked_skill_is_found — verifies deeply nested skills under symlinked dirs are discovered

What I intentionally did not change

• The security symlink-escape guards (write/remove still blocked)
• Any other skill discovery code paths
• External skill dirs behavior

[alt-glitch]

Competes with #35213 (same fix for #35184 — both replace rglob with iter_skill_index_files). Related to long-running #12624 and #7634.

[tonydwb]

Code Review Summary

Verdict: Approve

👍 Looks Good

• Correctly replaces rglob("SKILL.md") with iter_skill_index_files(skills_dir, "SKILL.md") which uses os.walk(followlinks=True) — fixes the inconsistent behavior where skills appeared in the system prompt index but were invisible to skill_manage
• Minimal change: only 2 call sites modified in _find_skill() and _find_skill_in_other_profiles(), 4 lines each (+1 import, -1 rglob, +1 iter_skill_index_files)
• Reuses existing iter_skill_index_files() which already handles EXCLUDED_SKILL_DIRS filtering — no new exclusion logic needed
• Tests properly mock the skills directory and verify symlinked (including nested) skills are discovered
• Uses tmp_path with symlink_to for clean, isolated test setup

✅ Verified

• 45 lines of tests covering both flat and nested symlink scenarios
• No behavioral change for non-symlinked skills
• Consistent with iter_skill_index_files() already used in prompt_builder.py

---

Reviewed by Hermes Agent

[alpindiay]

Automated Triage: Competing PRs Detected

Three PRs are independently fixing the same issue (symlink-discovery in skills, #35184):

• fix(skills): follow symlinks during skill discovery (#35184) #35213
• fix(skill_manager): follow symlinks when discovering skills (#35184) #35244 (this PR)
• fix: rglob follow symlinks for skill discovery #35299

They all modify tools/skill_management.py — only one can merge cleanly. Please coordinate and consolidate into a single PR.

[teknium1]

Thanks for aligning skill_manage discovery with the shared skill indexer. The current-main premise is valid: tools/skill_manager_tool.py:597 and :661 still use rglob("SKILL.md"), while agent/skill_utils.py:796 uses os.walk(..., followlinks=True).

Problems

• The new tests create symlinks without a platform-availability guard. Existing tests use pytest.skip after OSError/NotImplementedError (tests/agent/test_skill_utils.py:376-378); use the same pattern so restricted Windows environments do not fail the suite.
• Both discovery functions are changed, but the added tests only call _find_skill. Please cover _find_skill_in_other_profiles() as well; its current-main rglob site is tools/skill_manager_tool.py:661.

Suggested changes

• Add a cross-profile symlink regression test and platform-safe symlink setup.

Automated hermes-sweeper review.

[teknium1]

Please catch OSError and NotImplementedError here and pytest.skip when symlinks cannot be created. Existing symlink coverage uses that guard in tests/agent/test_skill_utils.py:376-378, which keeps restricted Windows environments from failing the suite.