Skip to content

fix(honcho): respect saveMessages in sync_turn - #35210

Open
Yahome wants to merge 1 commit into
NousResearch:mainfrom
Yahome:fix/honcho-save-messages-guard
Open

fix(honcho): respect saveMessages in sync_turn#35210
Yahome wants to merge 1 commit into
NousResearch:mainfrom
Yahome:fix/honcho-save-messages-guard

Conversation

@Yahome

@Yahome Yahome commented May 30, 2026

Copy link
Copy Markdown

Summary

  • respect Honcho saveMessages: false in HonchoMemoryProvider.sync_turn()
  • add regression tests for both disabled and enabled message persistence behavior
  • preserve explicit memory/conclusion writes (honcho_conclude) while blocking raw turn persistence

Why

HonchoClientConfig correctly parses saveMessages into save_messages, but sync_turn() did not check it before adding user/assistant messages and flushing them to Honcho. This meant users could configure tools-only / explicit-memory Honcho setups and still have full conversation turns persisted.

Test Plan

venv/bin/python -m pytest tests/test_honcho_save_messages.py -q
# 2 passed

venv/bin/python -m pytest tests/test_honcho_session_context.py tests/test_honcho_client_config.py -q
# 10 passed

venv/bin/python -m py_compile plugins/memory/honcho/__init__.py tests/test_honcho_save_messages.py
# passed

Live self-hosted Honcho validation with a honcho-test profile configured with saveMessages: false:

messages_before: 0
messages_after_sync_turn: 0
auto_sync_leaked_count: 0
conclude_ok: true
search_contains_fact: true
context_contains_fact: true

Fixes #35209

@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers P3 Low — cosmetic, nice to have labels May 30, 2026
@teknium1 teknium1 added sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users area/memory Memory subsystem: store, providers, sync, background reviews labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/memory Memory subsystem: store, providers, sync, background reviews comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(honcho): saveMessages=false does not prevent sync_turn from persisting messages

3 participants