fix(honcho): respect saveMessages in sync_turn - #35210
Open
Yahome wants to merge 1 commit into
Open
Conversation
This was referenced Jul 19, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveMessages: falseinHonchoMemoryProvider.sync_turn()honcho_conclude) while blocking raw turn persistenceWhy
HonchoClientConfigcorrectly parsessaveMessagesintosave_messages, butsync_turn()did not check it before adding user/assistant messages and flushing them to Honcho. This meant users could configure tools-only / explicit-memory Honcho setups and still have full conversation turns persisted.Test Plan
Live self-hosted Honcho validation with a
honcho-testprofile configured withsaveMessages: false:Fixes #35209