Skip to content

fix(slack): broaden bold-text zero-width-space guard to all non-word chars #35144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gonzalofrancoceballos wants to merge 1 commit into from
Closed

fix(slack): broaden bold-text zero-width-space guard to all non-word chars #35144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion gateway/platforms/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,9 +1255,19 @@ def _convert_header(m):
)

# 9) Convert bold: **text** → *text* (Slack bold)
# Slack's mrkdwn parser fails to recognize the closing * when it is
# immediately preceded by non-word characters (e.g. ), ], }, ., :, —).
# This causes the parser to silently truncate the rest of the message.
# Insert a zero-width space (U+200B) between the last character and
# the closing * whenever the last character is not alphanumeric or _.
def _convert_bold(m):
inner = m.group(1)
if inner and not (inner[-1].isalnum() or inner[-1] == '_'):
return _ph(f'*{inner}\u200b*')
return _ph(f'*{inner}*')
text = re.sub(
r'\*\*(.+?)\*\*',
lambda m: _ph(f'*{m.group(1)}*'),
_convert_bold,
text,
)

Expand Down