fix: add HERMES_SKIP_PROFILE_OVERRIDE escape hatch for launcher sandboxes - #35076
fix: add HERMES_SKIP_PROFILE_OVERRIDE escape hatch for launcher sandboxes#35076OmarB97 wants to merge 1 commit into
Conversation
|
Related: This appears to be a v2 resubmission of #33986 (same author/title, reduced from 19 files to 7 — scope creep removed). Also overlaps with #34332 which is a superset including HERMES_LLM_BASE_URL. Includes additional fixes: |
0ca392e to
af9c2cf
Compare
|
Scope update: force-pushed this branch to current Local verification: The broader |
1dfceb2 to
8032e5a
Compare
|
Rebased and refreshed this upstream mirror at head Current state:
I attempted the actual merge through |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
8032e5a to
0de74e3
Compare
|
Thanks for narrowing this to a focused profile-resolution change and adding a regression test. This automated hermes-sweeper review is closing it under the standing
This is a design-direction decision, not a judgment on the test coverage or implementation quality. Closed as not-planned per standing maintainer policy ( |
What
Why
How
Scope
This PR is intentionally narrowed to the profile-override escape hatch only:
hermes_cli/main.pytests/hermes_cli/test_apply_profile_override.pyThe broader
HERMES_LLM_BASE_URLruntime-provider work remains separate in #34332.Testing
Result:
5 passed in 0.23s.Risks / gaps
HERMES_SKIP_PROFILE_OVERRIDE=1.Relation to #22502
Main now trusts
HERMES_HOMEwhen its parent directory is literally namedprofiles(_apply_profile_overridestep 1.5). That heuristic does not cover launcher sandboxes whose scratch homes are not profile-shaped (e.g..../hermes-scratch/<run-id>/), so the unconditional override still clobbers them; this escape hatch remains necessary for that case.